If Smith won, would we be talking about “Smithvilles”? Would King Kong climb the Chrysler Building (Smith’s business ventures after 1928 led to the construction of the Empire State Building)?
Democrats dodged a real bullet in 1928, that they didn't in 1892.
A “poisoned chalice”. Hoover thought that soon poverty would be eradicated, but ended up ushering in a realignment against his party.
Yes, though it should be noted there were generational seeds being planted for that realignment already, it is just that the Depression was the motivating factor coalescing and pushing them towards the Democratic Party.
Would you say that Smith, like Goldwater in 1964, lost the election, but won the battle for the heart and soul of the Democratic Party and American politics in general?
Yes I would say so, as the first signs of urban situation becoming more like it is now certainly starts in 1928.
Also, Smith is now honored as the first Catholic nominee for President while Hoover is remembered as the person responsible for the Great Depression.
I wonder: What if a Republican with a more flexible personality was elected in 1928?
The Depression is still the depression, though Hoover was brutally effective at suppressing dissent in the Republican Party even as late as 1932.
Do you think a different Republican would have been more willing to drop tariffs and Prohibition like the party did after FDR’s inauguration?
Very hard to do that considering how entrenched the party was on those points. Also dropping tariffs kind of drops the whole crux of the GOP's urban support, that it preserved the industrial society through its tariffs.