LBJ's legislative legacy is far better than his foreign policy legacy. He passed the most important legislation of the latter 20th century, directly affecting the social make-up of the USA today.
The Voting Rights Act, the Civil Rights Act of 1964, and Housing Act effectively ended segregation, the Fair Immigration Law of 1965 eliminated the quota system and vastly increased the cultural diversity in the US, and of course Medicare.
The riots and demonstrations are long gone, and what is left from his presidency far better America than it would have been without him. It's why I put him in my Top Ten list.
LBJ had a great legislative legacy in terms of the Civil Rights Act of 1964 and the Voting Rights Act of 1965, but beyond that I think he did far more harm than good.
I think it's a great tragedy that LBJ followed up on his well-conceived plans to bring blacks into the mainstream with programs that encouraged the poor to rely more heavily on government programs. Liberalized welfare programs increased dependency, and encouraged the kind of behavior that can only result in poverty. Black illegitimacy, a strong predictor of poverty and criminality, jumped from 25% in 1965 to 70% today. LBJ's approach to crime (rehabilitation, not punishment) also helped lead to a tripling of the per-capita crime rate since the early 1960s.
The meltdown of the black family has undone a lot of the good in Johnson's civil rights platform. And largely because of this, racial separation (I won't call it segregation, since it's not imposed by law) has persisted throughout the country. Housing laws only go so far when millions of individual decisions, made on the basis of perceived self-interest, lead to continued separation of the races.
I think that if LBJ had backed programs designed to create self-sufficiency rather than dependency, and if his administration had been a little more realistic and a little less idealistic, those he wanted to help would be in a far better position today than they are.