So politics and whether the lawyer was actually a representative of the Russian government aside, is it illegal to work with a foreign government on a campaign if no favors are exchanged? Is it illegal to receive information from a foreign government for a campaign?
If all the people pretending to be outraged over Don Jr's 'treason' over trying to get oppo research from a foreign national were sincere in their beliefs they'd be outraged at Hillary Clinton working with the Ukrainian government in the course of the campaign. Instead they pretend 'that's different because muh reasons'
What would you say if it was Germany in 1936 vs Poland or Czechoslovakia?
That's really all in the eye of the beholder and irrelevant in a legal sense