Because it is a joke deal that doesn't stop Iran from being a rogue nation or from eventually getting nuclear weapons.
A rogue nation that gave Iraq advice and help in using chemical weapons, a rogue nation that broke the Geneva Convention, a rogue nation that toppled the Iranian Government in 1953, and a rogue government that has used it's UN veto to block even the most moderate action against Israel. Iran has done some absolutely things in the last 30 years but I don't think the US can lecture about. Israeli and US insecurity always cited 9/11 and Yom Kippur but the Iranians have 1953, the entire Shah's regime and the Iran-Iraq war where the US supporter Iraqi war crimes
Now onto the actual deal it actually brings Iran into the international fold-it has already been a rogue nation for the last 30 years and bar Iraq .2 I can't see how we could stop it from wanting to have it's own foreign policy-IIRC the Saudi's have been doing just as much as the Iranians to destabilize the region but you don't seem to oppose that. The claim that we're giving them money to spend on terrorism by uplifting sanctions is just silly because the rest of the world is already lifting the sanctions against Iran, and it will actually help the Iranian economy to develop-something I don't think is awful, they're humans as well.
The CIA said Iran would put the majority of the money back into it's own economy And yes the deal does stop Iran from getting nuclear weapons. It decreases there stockpiles of enriched uranium by 97%, they're stuck at enriching only at only 3% (they need 90% to get nuclear weapons) Besides even if Iran kicked out the inspectors, and went against every agreement, and somehow managed to rebuild all their equipment it would take them a year to make a bomb-currently it would take 3 months.
This deal isnt suppose to turn a shia theocracy into a secular democracy, it's not suppose to make Iran suddenly withdraw from the geopolitical stage-it's suppose to stop Iran from being able to build an atomic bomb, and it's about getting them back into the international arena