I'm trying to get an understanding of what the bases of the various parties in Weimar Germany were. Here's what I have so far:
NSDAP: Lower middle class types; small businessmen, low level civil servants, low level white collar workers etc.
SPD: Workers plus some progressive types.
KPD: Workers
Zentrum/BVP: Catholics of all classes
DNVP:] Landowners, industrialists, religious Protestants
DVP: Upper middle class professionals
DDP: Jews, Intellectuals
Questions:
1) Are any of these wrong?
Depends. What year are you asking? Obviously the remnant DDP and DVP support of 1933 was very different in localization from their support in 1920, when many local Liberal and National Liberal machines from the Kaiserreich were still in existence and getting the vote out. By 1933, both parties were wholly upper-middle-class urban and probably quite heavily Jewish.
Add "tenant farmers under traditional landlord influence" to the DNVP, of course, right down to the end in some places.
And then there's the story of the CSVD, an Evangelical splinter off the DNVP that got attacked by the DNVP for voting (with the few seats it ever got anywhere) largely as if it were the Center Party's fringe organization for Protestants.
Also, the Center's position in the wholly Catholic areas eroded quite a bit during Weimar... partially covered up in national results by improvements in mixed cities, not all of it coming from Catholics - Brüning got a personal vote here in the final years, as basically the Bourgeoisie's last hope outside of embracing Fascism. The votes lost, of course, went very largely to the Nazis - by 1933 easily the least sectarian party in Germany, although this is due to a specific swing in that last election - but (not everywhere) also to the Commies. But not to any other party whatsoever. Whatever inroads the SPD had made among Catholics all dates from pre 1918.
And then there's the farmer's parties, BBB and Landvolk. And the WP, a more urban lower-middle/small-businessman protest party, not far right of official position but totally serving, it and the Landvolk both, as a way-station from DVP/DDP (for WP) / DNVP (Landvolk) to the Nazis, and completely annihilated in 1932.
